[darcs-devel] [patch1738] resolve issue1959: no longer require write-access to the index for read-only commands
Ben Franksen
bugs at darcs.net
Mon Dec 10 12:55:33 UTC 2018
Ben Franksen <ben.franksen at online.de> added the comment:
> The reason is that you can't just remove read-only files on Windows,
> you have to change their permissions first. Using the newer
> removePathForcibly fixes this:
> https://hackage.haskell.org/package/directory-1.2.7.0/docs/System-
> Directory.html#v:removePathForcibly (we already depend on
> directory >= 1.2.7)
>
> Do you see any problem with replacing all uses of
> removeDirectoryRecursive with that? It's the one in withDir in
> Darcs.Util.Lock that really matters here, but there are a few
> others dotted around the codebase.
Sounds perfectly fine to me.
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1738>
__________________________________
More information about the darcs-devel
mailing list