[darcs-devel] [issue2567] darcs whatsnew --unified outputs wrong context lines

[Ben Franksen]

New submission from Ben Franksen <ben.franksen at online.de>:

The context calculation seems to be broken. Here is an example. The
recorded state is

1
2
3
4
5

This is the modified file:

1
3
4x
5

This is the expected output:

ben at yuiitsu[1]:/tmp/context>darcs whatsnew --unified
hunk ./file 2
 1
-2
 3
hunk ./file 3
-4
+4x
 5

and this is what you currently get:

ben at yuiitsu[1]:/tmp/context>darcs whatsnew --unified
hunk ./file 2
 1
-2
 3
 4
 5
hunk ./file 3
 1
 2
-4
+4x
 4
 5

I just tracked this down to:

patch 416f12b399c5fb1c64771302e80b54e68a40435c
Author: Ben Franksen <ben.franksen at online.de>
Date:   Thu Aug 31 23:37:43 CEST 2017
  * clean up display of file names by separating display and storage of
patches

I also found that we have no tests for the --unified flag (except for
darcs diff, but that is a different code path).

----------
messages: 19900
nosy: bf
status: unknown
title: darcs whatsnew --unified outputs wrong context lines

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue2567>
__________________________________