[darcs-devel] [patch1700] Consistent naming for working tree

Ben Franksen bugs at darcs.net
Sat Jul 14 15:56:17 UTC 2018


Ben Franksen <ben.franksen at online.de> added the comment:

There remain issues with the patch.

In D.R.Job the meaning is 'working directory' as stated, not 'working
tree'. Also in D.UI.Completion and D.Util.Tree.Monad and D.Util.Path and
in tests/mv.sh. In D.Util.Index only the first change in the module
header comment is correct, for the other two the meaning is 'directory',
not 'tree'.

In D.R.State, one of the changed comments no longer makes sense:
'Obtains a Tree corresponding to the complete working tree...'; this
should be shortened to 'Obtains the complete working tree...'. Also on
line 313 'working dir' should also be replaced with 'working tree'.

In D.R.Merge the debug message is not very helpful and should be
re-written to better conform to what is happening; but we can do that in
a separate patch.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1700>
__________________________________


More information about the darcs-devel mailing list