[darcs-devel] [issue2575] rebase pull leaves rebase patch in the repo if suspend is cancelled

[Ben Franksen]

New submission from Ben Franksen <ben.franksen at online.de>:

So I do a 'darcs rebase pull' say yes to everything until I see how many
patches it wants to suspend, perhaps look at a few of them. Then I say
'q' to cancel. I get

[...]
Shall I suspend this patch? (7/38)  [ynW...], or ? for more options: q
Suspend cancelled.
darcs: failed to read patch:
patch 9766caccd0af2009ad151588bd80100c3ba79cda
Author: Invalid <invalid at invalid>
Date:   Wed Mar  7 02:41:52 CET 2018
  * DO NOT TOUCH: Rebase patch
  This patch is an internal implementation detail of rebase, used to
  store suspended patches, and should not be visible in the user
  interface. Please report a bug if a darcs command is showing you this
  patch.
Patch not stored in patch bundle:
patch 9766caccd0af2009ad151588bd80100c3ba79cda
Author: Invalid <invalid at invalid>
Date:   Wed Mar  7 02:41:52 CET 2018
  * DO NOT TOUCH: Rebase patch
  This patch is an internal implementation detail of rebase, used to
  store suspended patches, and should not be visible in the user
  interface. Please report a bug if a darcs command is showing you this
  patch.

Apparently there is no test for this. The situation requires manual
editing of _darcs/hashed_inventory to fix. A must-fix before release IMO.

I have the suspicion that this could be due to the "nasty hack" (says
the comment, but I agree) in src/Darcs/UI/Commands/Rebase.hs line 731,
but I am not sure.

----------
messages: 19958
nosy: bf
priority: urgent
status: unknown
title: rebase pull leaves rebase patch in the repo if suspend is cancelled

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue2575>
__________________________________