[darcs-devel] [patch1659] several improvements to the test suite (unit tests)

[Guillaume Hoffmann]

Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

* harness: add option --full to run all tests in all variants

OK, nice.


  * fix in harness: show_read tested the wrong thing

Indeed. The idea of show_read is interating with the filesystem, not
with what the user sees.


  * harness: improve reports when properties fail


More detailed output on some tests failure, OK.


  * harness: improve output of patchAndInverseCommute

Slight improvement in output in case of failure, OK.

  * harness: code layout for property partialPermutivity

OK

  * darcs.cabal: clean up alignment

Mkay... that was not super necessary and will not commute with
many other patches in screened but well, that's it. OK.


  * harness: better output when property effectPreserving fails

Here comes the famous pretty-show dependency which you later remove in
a future patch.
There is also the introduction of flattenTree which uses Tree.list to
yield a flat representation of a Tree. Looks good.

  * darcs.cabal: add version limits for pretty-show
  
OK

  * harness: minor improvements and cleanups in generic properties

The call to commuteFLorComplain is replaced by commuteFL, which is almost
the same (see Darcs.Path.Commute). OK.

  * add tests for linesPS and unlinesPS, move properties from harnes to src

OK

  * cleanup of code layout and haddocks in D.T.U.TestResult

OK

  * harness: add instance Check p => Check (p:>p)

OK
  
Acceted

----------
status: needs-review -> accepted

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1659>
__________________________________