[darcs-devel] [patch1665] Many refactorings and cleanups, mostly for Darcs.Repository.Hashed

[Guillaume Hoffmann]

Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

Hi Ben,

Great bundle. These tests for inventory parsing and writing are an
important milestone. I agree with enabling no-warn-instances across the
whole source code: the cleanups in the plain vs bucketed caches are also
welcome.

You can screen the bundle as it is, if you want. I have a couple of
non-essential suggestions:

* we probably do not need the opinionated long comment of the patch
about set/unset
* avoid leaving out commented functions in D.R.Inventories
* the SM-exporting patch could be merged with the patch that uses this
import

Guillaume

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1665>
__________________________________