[darcs-devel] [patch1743] rename test for issue1702 to mark as fai... (and 3 more)

Ganesh Sittampalam bugs at darcs.net
Sat Nov 17 11:27:09 UTC 2018


Ganesh Sittampalam <ganesh at earth.li> added the comment:

>   * rename test for issue1702 to mark as failing

Fine, I've lost track of what's actually going on with this test,
but it's only a test and it was failing for me so I'm happy not
to have to worry about it more :-)

>  * fix in output of log command
>    I think the 'not' here got lost during a refactor.

This also changes a variable reference from 'files' to 'paths'
and doesn't compile for me yet (as you already warned about).
I'll come back to it once I find whatever other patch makes it work.

In general patches with "extra" changes often cause disproportionate
effort on the reviewing side for this kind of reason. But it's only
an occasional issue so no big deal, and to a large extent it's my
own fault for being so far behind on reviewing.

>  * eliminate hard-coded repo paths from the UI layer

Fine

>  * remove excessive debug output in D.R.HashedIO

Fine

----------
assignedto:  -> ganesh
nosy: +ganesh
status: needs-review -> review-in-progress

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1743>
__________________________________


More information about the darcs-devel mailing list