[darcs-devel] [patch1745] use AnchoredPath instead of FileName for... (and 8 more)

Ben Franksen bugs at darcs.net
Sun Nov 18 22:01:16 UTC 2018


Ben Franksen <ben.franksen at online.de> added the comment:

>> Is it expected that these changes affect the format of the patch
>> index? I'm seeing errors from binary in any commands that use the
>> patch index when I mix-and-match darcs binaries from before and after 
>> these changes. I haven't dug into the details yet.
> 
> An interesting observation. I have seen similar errors but I thought
> they were caused by my (not yet published) changes to the patch index.
> 
> To answer the question: no, these changes are not meant to affect the
> binary format of the patch index. If I had planned for that i would have
> increased the version number, causing the patch index to be re-created
> instead of giving an error. This is a bug and I will try to fix it.

I am an idiot. /Of course/ this change affects the binary format of the
patch index. Not only has AnchoredPath a different Binary instance, it
also has a different Ord instance so all the maps with paths as keys
change format etc. So while this wasn't intentional, it is clear that
the format is affected and thus we must increase the verson number. This
will cause the patch index to be re-created instead of crashing Darcs
with an unhandled exception. Will send and push a patch to that effect.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1745>
__________________________________


More information about the darcs-devel mailing list