[darcs-devel] [patch1856] tentativelyMergePatches: rename anonpend... (and 10 more)

Ganesh Sittampalam bugs at darcs.net
Mon Aug 5 14:27:22 UTC 2019


Ganesh Sittampalam <ganesh at earth.li> added the comment:

> patch c79cc65abec9b81565c804acade2a9b355f023fd
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sat Jul 13 11:25:34 CEST 2019
>   * some code cleanups for unsuspendCmd
>   
>   This factors out the check that there are no unrecorded changes 
>   into a local procedure that returns a Repository with
>   new witnesses if successful, or else dies.

OK. I'm not sure which style is superior, using IsEq <- ... to prove 
wR = wU for the rest of the do-block, or returning a new repository 
value, but I don't feel too strongly.

>   We also pass the command name to 'unsuspendCmd' to improve the
>   error message for the reify command and remove a number of
>   pattern type signatures that are no longer needed.

Looks good.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1856>
__________________________________


More information about the darcs-devel mailing list