[darcs-devel] [patch1860] add --not-in-remote option to amend and rebase unsuspend

Ben Franksen bugs at darcs.net
Mon Aug 5 15:36:58 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

>>   * refactor withSelectedPatchFromRepo
>>   
>>   It now gets an RL of patches instead of a Repository.
> 
> OK. Perhaps it should be renamed to something like 
> 'withSelectedPatchFromList'.

Yes. Will do.

>> Author: Ben Franksen <ben.franksen at online.de>
>> Date:   Fri Jul 19 11:18:19 CEST 2019
>>   * add --not-in-remote option to amend and rebase unsuspend
> 
> The patch description is wrong, it's actually for "rebase suspend" 
> (which makes much more sense).

Right, sorry about that.

> I guess that 'preselectPatches' could be factored out into something 
> more central than D.UI.C.Unrecord.

Yes, we have D.UI.C.Util for stuff like that. Will do.

> It's unfortunate that we can't share the code for --not-in-remote 
> between amend and obliterate/rebase suspend, but not surprising 
> given that amend is single-select and the others are multi-select.

Whether we select a single patch or many should be configurable instead
of requiring a different call. Refactoring this so that we have less
code duplication is also on my long-term todo list.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1860>
__________________________________


More information about the darcs-devel mailing list