[darcs-devel] [patch1876] turn an error call into a proper failure when cloning

[Ben Franksen]

New submission from Ben Franksen <ben.franksen at online.de>:

This one may need careful review, though I am pretty confident the refactors
are sound.

1 patch for repository http://darcs.net/screened:

patch 71465505ff2739ec188389590751f0d82ade6dc1
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Aug  2 19:06:48 CEST 2019
  * turn an error call into a proper failure when cloning
  
  This patch also cleans up the surrounding code:
   * find uncommon patches only once instead of twice
   * replace repeated calls to lengthFL with a let-bound variable
   * rename some variables
   * remove unneeded calls to hopefully and effect
  Regarding the last change, note that (apply . effect) is strictly inferior
  to the plain apply, since the latter is hopefully optimized via applyPrimFL.

----------
files: patch-preview.txt, turn-an-error-call-into-a-proper-failure-when-cloning.dpatch, unnamed
messages: 21107
nosy: bf
status: needs-screening
title: turn an error call into a proper failure when cloning

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1876>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 3976 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190815/3e50a4cf/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: turn-an-error-call-into-a-proper-failure-when-cloning.dpatch
Type: application/x-darcs-patch
Size: 42698 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190815/3e50a4cf/attachment-0003.bin>
-------------- next part --------------
.