[darcs-devel] [patch1893] tests: always use 'tar -f -' to work with stdin/out

Ben Franksen bugs at darcs.net
Mon Aug 26 14:52:07 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

> I'm going to push this to reviewed now because it's
> pretty trivial and I need it to get clean test runs, but
> any comments just let me know and I can follow up.

It would be nice if we could either

 * gather restrictions/pitfalls like that (and recipes to avoid them)
   somehwere e.g. tests/README

 * or, even better, add small shell functions to tests/lib to use,
   instead of the raw commands, where that is problematic.

For instance, we could add

unpack_testdata () {
  # on Windows we cannot use the -f option
  tar xz < $TESTDATA/$1
}

and use it in shell scripts as

unpack_testdata old-style-rebase.tgz

Since much of test script writing is copy-and-paste anyway, this would
more or less automatically proliferate to new scripts...

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1893>
__________________________________


More information about the darcs-devel mailing list