[darcs-devel] [patch1884] extend test script for pristine conversion (and 2 more)

[Ben Franksen]

Ben Franksen <ben.franksen at online.de> added the comment:

>> Since this is the test harness and not code for darcs proper, couldn't
>> we just fix/adapt harness.sh and deal with any remaining "subtle
>> effects" whenever we notice them?
> 
> All the problems are orthogonal, but it takes work to discover that so
> I'd rather just eliminate one variable.

Okay, this is absolutely fine with me.

>>       -- .... Failing that we could do the translation here and then do some
>>      -- checks in lib/env that the inherited env matches the script's env.
>>
>> I may be wrong but I think such a check would defeat the purpose of
>> being able to run the tests without the harness.
> 
> I meant when running in the test harness. Actually perhaps the checks
> would better belong in a separate test that we'd never want to run for
> any other reason.
> 
> I'll update that comment and look at using splitSearchPath, once I've
> fixed my working environment.

Good! And thanks for trying to fix darcs on Windows! I would really like
us to get out the next release with a working Windows binary that is
easy to install and has been well-tested.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1884>
__________________________________