[darcs-devel] [patch1884] extend test script for pristine conversion (and 2 more)

[Ben Franksen]

Ben Franksen <ben.franksen at online.de> added the comment:

> I did a bit more research and discovered there is
> an easy way to translate the paths for Windows.
> 
> I couldn't see an elegant way to handle all the
> different cases directly (direct env injection/bash
> script on Linux/bash script on Windows) so ended up
> introducing a new datatype to make everything
> explicit.
> 
> 1 patch for repository darcs-unstable at darcs.net:screened:
> 
> patch 95ae5700feba1c19016b9711167ef3400c50fe88
> Author: Ganesh Sittampalam <ganesh at earth.li>
> Date:   Mon Aug 26 21:18:43 BST 2019
>   * harness: properly translate env script on Windows
>   
>   We have Windows paths in Haskell but we need
>   Unix style paths in the env script

Beautiful! The data type is absolutely the right thing to do here.

At this point we may want to move all the code that concerns (only)
shell tests from test.hs to a its own module Darcs.Test.Shell.

Anyway, all accepted (including mine).

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1884>
__________________________________