[darcs-devel] [patch1795] accept issue2618: option --ask-deps adds too many depe...

Ben Franksen bugs at darcs.net
Thu Jan 24 18:32:22 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

Now with a fix, too.

3 patches for repository http://darcs.net/screened:

patch 89dac3b4e27fcd8a161b3649da6a39dd152d5832
Author: Ben Franksen <ben.franksen at online.de>
Date:   Thu Jan 24 17:34:49 CET 2019
  * accept issue2618: option --ask-deps adds too many dependencies

patch bc4a10b1347bc072bcaa0635653e00a6dc456ac7
Author: Ben Franksen <ben.franksen at online.de>
Date:   Thu Jan 24 19:21:25 CET 2019
  * small improvement to test for issue2618

patch 1b950fc692074d8a2081925904bb8a48ed77ac18
Author: Ben Franksen <ben.franksen at online.de>
Date:   Thu Jan 24 19:21:59 CET 2019
  * resolve issue2618: option --ask-deps adds too many dependencies
  
  The trick is to filter out any patches in the result from runSelection that
  depend on later ones. While this may also filter out explicitly selected
  patches, these should rightfully not have been offered in the first place.
  I took the freedom to clean up and simplify the code for askAboutDepends.
  This concerns mainly the initial filtering of patches that are depended on
  by what we record, which is now reduced to a plain commuteWhatWeCanRL.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1795>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 4895 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190124/23e3618c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch
Type: application/x-darcs-patch
Size: 35881 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190124/23e3618c/attachment-0003.bin>
-------------- next part --------------
.






More information about the darcs-devel mailing list