[darcs-devel] [patch1795] accept issue2618: option --ask-deps adds too many depe...

Ben Franksen bugs at darcs.net
Thu Jan 24 18:39:19 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

Forgot to rename the test to indicate it is no longer failing; also rebased
the accept patch to squash with the improvement.

2 patches for repository http://darcs.net/screened:

patch fd8ec00c01bff2f09b5b1c3dabb22f09b2d04a5e
Author: Ben Franksen <ben.franksen at online.de>
Date:   Thu Jan 24 19:36:18 CET 2019
  * accept issue2618: option --ask-deps adds too many dependencies

patch e4a9cd9363e62946e78b5a602d1e373a0f27640d
Author: Ben Franksen <ben.franksen at online.de>
Date:   Thu Jan 24 19:36:55 CET 2019
  * resolve issue2618: option --ask-deps adds too many dependencies
  
  The trick is to filter out any patches in the result from runSelection that
  depend on later ones. While this may also filter out explicitly selected
  patches, these should rightfully not have been offered in the first place.
  I took the freedom to clean up and simplify the code for askAboutDepends.
  This concerns mainly the initial filtering of patches that are depended on
  by what we record, which is now reduced to a plain commuteWhatWeCanRL.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1795>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 4738 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190124/f3158a97/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: accept-issue2618_-option-__ask_deps-adds-too-many-dependencies.dpatch
Type: application/x-darcs-patch
Size: 35724 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190124/f3158a97/attachment-0003.bin>
-------------- next part --------------
.





More information about the darcs-devel mailing list