[darcs-devel] [issue1461] case-folding can lead to working directory corruption

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

On 13/07/2019 17:52, Ben Franksen wrote:

>> I think that as it happens all these specific cases (atomic patches that
>> add a and remove A, or one that moves A to a) are perfectly safe. The
>> atomicity of the patches guarantees they are never both present no
>> matter what the patch ordering.
> 
> Any patch that conflicts with, say, the 'rm A' will have the effect of
> 'add A' and will thus be treated... how?

You're right. Only 'move A a' is safe.

> As it's "only" the working tree that breaks, perhaps it suffices to
> reliably detect the situation and instruct the user that they should
> rename or remove one of the files to make the problem go away; and also
> warn them that this "fix" may not be permanent i.e. the problem may
> re-appear if they re-order patches. That shouldn't be too hard to do.

That's probably ok, though I'm not entirely sure how they'd actually
record the patch to do that if they don't have access to a non-Windows
machine. But there are various options available to a user familiar
enough with darcs so I'm still not that bothered about the situation.

Ganesh

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue1461>
__________________________________