[darcs-devel] [patch1845] fix typo in a comment (and 21 more)

Ganesh Sittampalam bugs at darcs.net
Sun Jul 28 14:04:05 UTC 2019


Ganesh Sittampalam <ganesh at earth.li> added the comment:

> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Jun 30 20:18:37 CEST 2019
>   * simplify instances Eq2 for RebaseName and RebaseFixup

> hunk ./src/Darcs/Patch/Rebase/Fixup.hs 69
> - -    PrimFixup _ `unsafeCompare` _ = False
> - -    _ `unsafeCompare` PrimFixup _ = False
> - -
> hunk ./src/Darcs/Patch/Rebase/Fixup.hs 70
> - -    -- NameFixup _ `unsafeCompare` _ = False
> - -    -- _ `unsafeCompare` NameFixup _ = False
> +    _ `unsafeCompare` _ = False
> hunk ./src/Darcs/Patch/Rebase/Name.hs 138
> - -   AddName _ `unsafeCompare` _ = False
> - -   _ `unsafeCompare` AddName _ = False
> - -
> hunk ./src/Darcs/Patch/Rebase/Name.hs 139
> - -   DelName _ `unsafeCompare` _ = False
> - -   _ `unsafeCompare` DelName _ = False
> - -
> hunk ./src/Darcs/Patch/Rebase/Name.hs 140
> - -   -- Rename _ _  `unsafeCompare` _ = False
> - -   -- _ `unsafeCompare` Rename _ _  = False
> +   _ `unsafeCompare` _ = False

The previous style here was actually deliberately verbose, to make 
sure we would get pattern match warnings if a new constructor is 
added. It's not a big deal, but I'd rather we roll this back.

All the rest look good.

----------
status: needs-review -> review-in-progress

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1845>
__________________________________


More information about the darcs-devel mailing list