[darcs-devel] [patch1846] improved test case generator for RepoPatches (and some more)

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

> patch b5f82f0bd3b4a6c02d4f5ca39a86b1ee876da43a
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Fri Jun 21 21:47:26 CEST 2019
>   * harness: move nontrivialX conditions to D.T.P.A.Generic and 
>     remove dead code

OK

 
> patch 94f6ecd73fa1a64c7d6713e47c74e8e5a0f2a3b7
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Fri Jun 21 15:41:36 CEST 2019
>   * harness: remove a dirty hack from patch tree generators
>   
>   This re-adds a slightly modified version of sizeTree which we 
>   use to
>   calculate the number of pairs in a flattened Tree.

OK

> patch 075808841224ddd930f041c723ae21ede6bb723e
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Jul  7 10:16:26 CEST 2019
>   * harness: make sure once and for all that generated Trees
>     have enough patches

OK

> patch 846bc17be395d01b82257f66aedfadf187caafb5
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Jul  7 10:15:44 CEST 2019
>   * harness: minor cleanups in D.T.P.A.Generic
OK 
> patch 47cc5a8ba40f7b43e8611678d8f5949f578b7ac4
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Fri Jun 28 10:43:09 CEST 2019
>   * harness: make encoding roundtrip test faster
OK

 
> patch d3cf9a7597b52a79209afe80ee12d9778637ce84
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Jul  7 08:43:00 CEST 2019
>   * harness: treat empty hunks specially in checkPatch
>   
>   See the comment in the code. I wonder why this hasn't come
>   up earlier.

OK. 

> patch b0a689417ade345d2f7b60e7d8969439a96d5710
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Jul  7 10:00:51 CEST 2019
>   * harness: remove code we no longer need

OK

> patch 5f2996bf7f298c8445740f9fe847fc046dbfd17c
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Jul  7 10:00:08 CEST 2019
>   * harness: never generate empty hunks

OK

> patch 08d6977bb518bca5024ecad7e87fc6fd29055d79
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Mon Jun 24 08:30:22 CEST 2019
>   * improved test case generator for RepoPatches
>   
>   We previously generated RepoPatches by merging prims from a 
>   Tree. While this
>   generates conflictors, it never generates sequences where a
>   patch depends on
>   a conflictor. The new generator (which can only be used for
>   patch types that
>   have a Merge instance i.e. not prims) directly generates an RL
>   of patches,
>   making sure we cover all possible cases.

Nice, thanks.

> patch 39f81cf1b5ebc727677b74fe97e20578af520f2f
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Thu Jul  4 22:22:53 CEST 2019
>   * harness: limit number of flattenings in
>     propConsistentTreeFlattenings
>   
>   The number of flattenings grows exponentially in the worst case, 
>   so this
>   helps to keep the test reasonably efficient even if we crank up 
>   the number of QC tests.

OK

----------
status: needs-review -> accepted-pending-tests

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1846>
__________________________________