[darcs-devel] [patch1797] add --replay=SEED option to darcs-test (and 20 more)

Ganesh Sittampalam bugs at darcs.net
Mon Jun 3 19:26:42 UTC 2019


Ganesh Sittampalam <ganesh at earth.li> added the comment:

>   * add --replay=SEED option to darcs-test

OK

>   * improve test for conflict chain resolution
>   * mark test for resolution of conflict chains as not failing

OK

>   * harness: better diagnosis when permutivity fails

OK

>   * rollback of rename conflictedEffect to isConflicted

OK

>   * better diagnostics when property mergeEitherWay fails

OK

>   * remove obsolete directory src/Darcs/Patch/Bracketed

OK

>   * small layout fix in Darcs.Util.Hash

> -  get = do a <- get ; b <- get ; c <- get ; d <- get ; e <- get ;
return (SHA1 a b c d e)
> +  get = do a <- get; b <- get; c <- get; d <- get; e <- get; return
(SHA1 a b c d e)

OK (though we have Applicative these days :-))

>   * fix crash when a hash (given with -h) is not found

OK

>   * break overlong lines in D.R.Repair

OK

>   * tests/sshlib: skip test if remote darcs doesn't understand our patch format

OK

>   * remove test repos before creating them (apply, apply-hunks)

OK

>   * tests/apply-hunks.sh: remove step6

OK

>   * renamed apply-hunks.sh to issue701.sh

OK

>   * fix shebang line in tests/conflict-fight-failure.sh

OK

>   * tests/conflict-fight-failure: adapt number of iterations to patch format

OK (a comment about the rationale for the counts might be nice)

>   * simplify and clean up conflict-fight test scripts

OK

>   * make test for issue1978 independent of patch format

OK

>   * replace use of fromAnonymousPrim with call to constructor
>   
>   This further minimizes calls to fromAnonymousPrim which is good because with
>   V3 this is now an unsafe method.

OK [The patch description is wrong - talks about fromAnonymousPrim
rather than fromPrim - perhaps commuted with a rename in your pending code?]

>   * use mergeNoConflicts in the definition of standardResolution

OK

>   * tests/repair.sh: group remove of test repo with creation

OK

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1797>
__________________________________


More information about the darcs-devel mailing list