[darcs-devel] [patch1791] fix several uses of error where it shoul... (and 7 more)

Ben Franksen bugs at darcs.net
Tue Jun 11 14:38:45 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

>>  * add new Exception types CommuteCommonPatches and PatchNotAvailable
>   
>>  We now throw these special exceptions instead of calling error. This is
>>  because neither is (necessarily) a bug in Darcs. Instead these 
> exceptions
>>  can be thrown under normal conditions and indeed there are tests that
>>  provoke these failures.
> 
> Same reservation as the other two cases - I don't know
> what the user is supposed to do when they hit these.

I think I made the CommuteCommonPatches change when i still thought
merge-by-value could be made to work. This should really be an error/bug
in darcs. We should rollback this change.

The PatchNotAvailable change is sound because this exception is usually
triggered by lazy repos, so the user should try and make their repo
complete.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1791>
__________________________________


More information about the darcs-devel mailing list