[darcs-devel] [patch1797] add --replay=SEED option to darcs-test (and 20 more)

[Ben Franksen]

Ben Franksen <ben.franksen at online.de> added the comment:

>>   * small layout fix in Darcs.Util.Hash
> 
>> -  get = do a <- get ; b <- get ; c <- get ; d <- get ; e <- get ;
> return (SHA1 a b c d e)
>> +  get = do a <- get; b <- get; c <- get; d <- get; e <- get; return
> (SHA1 a b c d e)
> 
> OK (though we have Applicative these days :-))

Oh my goodness. I have no idea why i haven't made this change in the
first place, probably didn't want to be distracted...

>>   * tests/conflict-fight-failure: adapt number of iterations to patch format
> 
> OK (a comment about the rationale for the counts might be nice)

Right, though I guess you'll notice soon enough once you play with the
numbers...

>>   * replace use of fromAnonymousPrim with call to constructor
>>   
>>   This further minimizes calls to fromAnonymousPrim which is good because with
>>   V3 this is now an unsafe method.
> 
> OK [The patch description is wrong - talks about fromAnonymousPrim
> rather than fromPrim - perhaps commuted with a rename in your pending code?]

Yes, definitely. Sorry about that.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1797>
__________________________________