[darcs-devel] [patch1829] v3: use attoparsec to replace our own parser monad

[Ben Franksen]

New submission from Ben Franksen <ben.franksen at online.de>:

The second to last patch "rename module Darcs.Patch.Parse to
Darcs.Util.Parser" wasn't contained in the original large bundle because it
conflicted with screened. I rebased and added it because I think it belongs
here.

6 patches for repository /home/ben/src/darcs/without-v3:

patch f7fc2f06d8e41aeeafb76ddf2457fbca1b3c04e2
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Feb  8 17:46:49 CET 2019
  * restore alphabetical order of exposed-modules in darcs.cabal

patch 0cae5acc67078b6cc2b6b0cbe5137a19522ec553
Author: Ben Franksen <ben.franksen at online.de>
Date:   Sun Feb 17 12:12:56 CET 2019
  * replace our own patch parser with attoparsec
  
  We already depend on attoparsec for convert import and its functionality and
  implementation is quite similar to our self-written parser monad. I have
  checked that this does not impact performance negatively.

patch 27448d5c3ee98412c4331329bbcf874c8e87812f
Author: Ben Franksen <ben.franksen at online.de>
Date:   Sun Feb 17 12:22:58 CET 2019
  * take advantage of attoparsec error message for patches and inventories
  
  This changes the return type of readPatch and parseInventory from Maybe to
  Either String. Attoparsec's error messages are weak but that's still better
  than none at all.

patch bbe57ddc7d2380c0d2b2f568f32b1e1c7ab6d659
Author: Ben Franksen <ben.franksen at online.de>
Date:   Sun Feb 17 17:20:19 CET 2019
  * replace parseStrictly with parse everywhere
  
  This is not a simple rename but changes the output type from Maybe to Either
  String throughout.

patch 70fbba0a41bc042648dc8c9ed23b806b870e7078
Author: Ben Franksen <ben.franksen at online.de>
Date:   Sun Feb 17 21:25:39 CET 2019
  * rename module Darcs.Patch.Parse to Darcs.Util.Parser
  
  There is nothing specific to patches in this module, in fact we use it for
  inventories as well.

patch 3dc3501824692790cf4bcfa487416c76b77073c8
Author: Ben Franksen <ben.franksen at online.de>
Date:   Sun Feb 17 21:32:00 CET 2019
  * restore alphabetical order of modules in darcs.cabal

----------
files: patch-preview.txt, restore-alphabetical-order-of-exposed_modules-in-darcs_cabal.dpatch, unnamed
messages: 20822
nosy: bf
status: needs-screening
title: v3: use attoparsec to replace our own parser monad

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1829>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 42994 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190615/66af7c6f/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: restore-alphabetical-order-of-exposed_modules-in-darcs_cabal.dpatch
Type: application/x-darcs-patch
Size: 82628 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190615/66af7c6f/attachment-0003.bin>
-------------- next part --------------
.