[darcs-devel] [patch1901] fix interpretation of bundles as patchsets

Ben Franksen bugs at darcs.net
Mon Sep 2 20:34:55 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

> 1 patch for repository http://darcs.net/screened:
> 
> patch d1bbdb5f1f3cea279a92649f989f68f63c37f71e
> Author: Ben Franksen <ben.franksen at online.de>
> Date:   Sun Sep  1 15:19:00 CEST 2019
>   * fix interpretation of bundles as patchsets
>   
>   We previously created invalid patchsets when a tag was present in the
>   context of a bundle. This worked (sort of) due to laziness but only if we
>   actually have that tag in our repo. If we don't then this rather dirty hack
>   interprets the bundle in a wrong context, i.e. Origin. Depending on how
>   findCommonAndUncommon is implemented we either get immediate errors ("cannot
>   commute common patches") or it hangs indefinitely trying to perform huge
>   amounts of bugus commutes of patches that aren't in their rightful context.
>   
>   The same bug is still present in scanContextFile.

I am working on a re-write of Darcs.Patch.Bundle to use
Darcs.Util.Parser instead of re-implementing parser combinators inlined
in the code which I find horribly unreadable. In the end this will also
contain a fix of scanContextFile along the same lines as the fix I sent
above.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1901>
__________________________________


More information about the darcs-devel mailing list