[darcs-devel] [patch1911] WIP: use Prim patches in rebase toedit

Ben Franksen bugs at darcs.net
Wed Sep 11 10:57:16 UTC 2019


Ben Franksen <ben.franksen at online.de> added the comment:

Let me come back to the suggestion I made in msg21370:

> That is, ToEdit will have to consist of a PatchInfo plus explicit 
> dependencies, plus a /sequence/ of (fixup;patch), not just a single
> one.
> 
> This could be done by embedding a Named (RebasePatch prim), where 
> (RebasePatch prim) lives at the same level as (RepoPatchVx prim) and 
> consists of (fixups;prim) or perhaps even (fixups;prim;fixups). The 
> latter would be particularly elegant, as unwind would then become a 
> patch converter:
> 
> unwind : p wX wY -> RebasePatch (PrimOf p) wX wY
I really think this is the correct way to get rid of the hacky
implementation of Unwind for FLs where you squash the intermediate
fixups using canonize/coalesce. This hack is making me quite nervous and
I would hope that with the idea sketched above we could completely avoid it.

I am pretty much interested in getting this re-design of rebase into a
usable shape because of patch1913. If we can find an implementation of
force-commute that directly works on (RebasePatch prim), then patch1913
could easily be completed, allowing us to remove all the bogus Regrem
and Rotcilfnoc pseudo inverses. (BTW, one patch in that bundle already
removes the Rev constructors for RebaseChange and RebaseSelect together
with zillions of error calls.)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1911>
__________________________________


More information about the darcs-devel mailing list