[darcs-devel] [patch1880] decouple RepoPatchV3 impl from NamedPrim

[Ben Franksen]

> patch b30e3fccbe39ab771e551d6d516683ddca738b7e
> Author: Ganesh Sittampalam <ganesh at earth.li>
> Date:   Tue Aug 27 13:36:20 CEST 2019
>   * Refactor the commute implementation for NamedPrims
>   
>   It now just relies on the Ident class instead of the internals.
>   This also distinguishes a case that ought to be an internal error,
>   but the unit tests seem to rely on it, so this is left as a
>   TODO for now.

Okay. A follow-up (patch1898) will fix the test case generator to
generate suitably unique hashes and insert the error call here.

> patch 403b46b4a02845a8cd2d3b63eef285d734195245
> Author: Ganesh Sittampalam <ganesh at earth.li>
> Date:   Tue Aug 27 13:44:48 CEST 2019
>   * introduce PrimWithName and make NamedPrim a type synonym

Okay. I am not overly fond of the added class StorableId (and the extra
contexts required in V3.Core) but I can't see a better solution and it's
pretty much in line with our other interfaces.

> patch ad42379e60af4a3d80757921eba3de557b65b9ff
> Author: Ganesh Sittampalam <ganesh at earth.li>
> Date:   Mon Sep  2 11:25:25 CEST 2019
>   * make D.P.V3.Core independent of PrimPatchId/Prim.Named
>   
>   This involves moving the FromPrim instance to V3.hs and
>   generalising the pattern synonyms used by the test harness.
>   
>   We now expose the constructors of RepoPatchV3 from D.P.V3.Core
>   (but not from D.P.V3, which is the intended external interface).

Fine.

> patch dfcdb9ed135d06195957646175224023ec5bb147
> Author: Ganesh Sittampalam <ganesh at earth.li>
> Date:   Mon Sep  2 12:18:02 CEST 2019
>   * add missing haddock to PrimWithName

Good.

Will push all to reviewed, including one already accepted dependency.