[darcs-devel] [patch1913] WIP: get rid of Invert instances for non-prim patch types
Ganesh Sittampalam
bugs at darcs.net
Tue Sep 24 20:09:40 UTC 2019
Ganesh Sittampalam <ganesh at earth.li> added the comment:
> * use Invertible when calling lookTouch in log command
Fine
> * use effect to avoid inversion of non-prims in externalResolution
> + -> WantGuiPause -- ^ tell whether we want GUI pause
I guess docs are generally good, but this one seems a bit redundant :-)
> + -> FL p wY wA -- ^ them merged (standard_resolution)
This doc is a bit cryptic, though it's better than not having one at all.
> - nas = effectOnPaths (invert pmerged) nms
> + nas = effectOnPaths (invert (effect pmerged)) nms
This feels a bit awkward though it doesn't really matter in practice.
Couldn't you have used mkInvertible?
> * use Invertible to generalize runSelection
Fine
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1913>
__________________________________
More information about the darcs-devel
mailing list