[darcs-devel] [patch1938] remove instances of Annotate RepoPatch

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

The annotatePIAP refactor does pass all the tests. Let me
know what you think.

In an ideal world I would write some tests for annotating
conflicts and see if we've regressed (or vice-versa) but I'm
not too keen on spending the effort right now.

2 patches for repository darcs-unstable at darcs.net:screened:

patch 540b726979f01607d7f97df89f69a1c09ede385b
Author: Ganesh Sittampalam <ganesh at earth.li>
Date:   Wed Sep 25 23:36:48 BST 2019
  * Bugfix for "remove instances of Annotate for repo patches"
  
  We were inadvertently calling annotateRP on PatchInfoAnd,
  and omitting the reverseFL that was previously called in
  instance Annotate Named.

patch 4d368fbb25a148c5cab6d8a19b63629be28cac8f
Author: Ganesh Sittampalam <ganesh at earth.li>
Date:   Thu Sep 26 16:40:52 BST 2019
  * inline annotateRP and instance Annotate RL and simplify
  
  The new definition should be equivalent on unconflicted
  patches. For conflicts it may not be identical but this
  is probably not a well-supported case anyway and we don't
  have any tests to specify the expected behaviour.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1938>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 1945 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190926/2a470116/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bugfix-for-_remove-instances-of-annotate-for-repo-patches_.dpatch
Type: application/x-darcs-patch
Size: 7417 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190926/2a470116/attachment-0001.bin>
-------------- next part --------------
.