[darcs-devel] [patch1932] fix doc comment for filterDirContents (and 13 more)

Ben Franksen ben.franksen at online.de
Thu Sep 26 22:09:10 UTC 2019


>>> Fine. Now we have the new HTTP downloading could we just drop -fcurl?>> As long as it doesn't hurt us seriously I would like us to keep it.
> OK. It's just more complexity, including configuration and some C files,
> I don't plan to pay any attention to keeping it working on Windows though.

I am fine with that.

>>>>   * fallback to simplePrinters if fancyPrinters throws exception
>>>
>> My justification for using catchall here was that we don't loose
>> anything significant, just coloring. I don't think the exeption in
>> question was an IO error because I would have used catchIOError in that
>> case.
> 
> I see these options, in order of preference for me (I could live with
> any of them):
> 
>  - remove the catchall and wait for it to fail again, and analyse the
>    actual causes

Agreed, will send follow-up.



More information about the darcs-devel mailing list