[darcs-devel] [patch1931] remove isInverted from PatchInfo

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

This version renames the isInverted flag to _piLegacyIsInverted
and removes all the code that treated it specially.

I've also added a test. I didn't try to test commuteNameNamed
as it'd be a bit of a pain to setup a test case for that.

I won't screen immediately.

1 patch for repository darcs-unstable at darcs.net:screened:

patch acd0f71ccea2796bb166c7da9594729854de0071
Author: Ganesh Sittampalam <ganesh at earth.li>
Date:   Fri Sep 27 10:29:36 BST 2019
  * treat the PatchInfo isInverted flag as legacy
  
  Now that Named patches can't be inverted, it doesn't make
  sense to invert PatchInfos either.
  
  However patches with this flag set were historically written
  out by 'darcs rollback' until around 2008, so we need some
  residual support.
  
  The approach is to treat it like the other flags in
  PatchInfo and for it not to be anything to do with actual
  patch inversion any more.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1931>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 19387 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190927/6cee29da/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: treat-the-patchinfo-isinverted-flag-as-legacy.dpatch
Type: application/x-darcs-patch
Size: 32238 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20190927/6cee29da/attachment-0003.bin>
-------------- next part --------------
.