[darcs-devel] [patch1943] get rid of the PrimPatchBase superclass for Summary

Ganesh Sittampalam bugs at darcs.net
Fri Sep 27 16:11:04 UTC 2019


Ganesh Sittampalam <ganesh at earth.li> added the comment:

> I don't get it. How does this simplify anything? I see a clear increase
> in complexity of constraints, overall. Also, I don't understand what's
> so unpleasant about the occasional extra PrimPatch or PrimPatchBase
> constraint (3 alltogether in your patch).

I was actually provoked to do it by some nasty cascading constraints
that the PrimPatchBase superclass entailed when doing the rebase
refactoring, so to some extent it was about preventing future complexity
as well. But I can't remember the exact details now and can't quickly
reproduce them. I expect I'll come across them again as I continue
cleaning up that refactoring.

As a general principle I think this is a bad superclass though. Why
should we need all the stuff in PrimPatch (PrimOf p) just to be able to
implement Summary? It obscures the modularity of our code when we have
huge constraints on instances.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1943>
__________________________________


More information about the darcs-devel mailing list