[darcs-devel] [issue2655] darcs-2.16.1 fails to build on ghc-8.8:: PACKAGE_VERSION is not defined

[Sergei Trofimovich]

New submission from Sergei Trofimovich <slyfox at gentoo.org>:

It's an upstream bug report of downstream https://bugs.gentoo.org/737236

Excerpt from full build'log at https://737236.bugs.gentoo.org/attachment.cgi?id=654756

"""
src/hscurl.c:50:12: error:
     error: expected ‘,’ or ‘;’ before ‘PACKAGE_VERSION’
       50 |   "darcs/" PACKAGE_VERSION " libcurl/" LIBCURL_VERSION;
          |            ^~~~~~~~~~~~~~~
   |
50 |   "darcs/" PACKAGE_VERSION " libcurl/" LIBCURL_VERSION;
   |            ^
`x86_64-pc-linux-gnu-gcc' failed in phase `C Compiler'. (Exit code: 1)
"""

I think it happens because ghc-8.8 (And/or Cabal-3?) does not define
PACKAGE_VERSION and defines CURRENT_PACKAGE_VERSION instead:

"""
$ fgrep -R PACKAGE_VERSION .
./dist/build/autogen/cabal_macros.h:#ifndef CURRENT_PACKAGE_VERSION
./dist/build/autogen/cabal_macros.h:#define CURRENT_PACKAGE_VERSION "2.16.1"
./dist/build/autogen/cabal_macros.h:#endif /* CURRENT_PACKAGE_VERSION */
./src/hscurl.c:  "darcs/" PACKAGE_VERSION " libcurl/" LIBCURL_VERSION;
./CHANGELOG:   * 1824: avoid PACKAGE_VERSION under Windows
"""

-- 

  Sergei

----------
messages: 22441
nosy: slyfox
status: unknown
title: darcs-2.16.1 fails to build on ghc-8.8:: PACKAGE_VERSION is not defined

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue2655>
__________________________________