[darcs-devel] [patch2131] make writeUnrevert take its arguments in... (and 8 more)

Ben Franksen bugs at darcs.net
Sun Dec 20 07:15:01 UTC 2020


New submission from Ben Franksen <ben.franksen at online.de>:

This is a first series of patches pulled from by experimental branch. They
are all about unrevert and not supposed to change behavior, it's pure
refactors.

9 patches for repository http://darcs.net/screened:

patch f603d95c27a5f143a6ec10593ad0c96876ba5713
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 11:50:51 CEST 2020
  * make writeUnrevert take its arguments in a more natural order

patch 768c25e2f0de602588714759f62d831dcbadd440
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 15:33:20 CEST 2020
  * unrevert: rename some local variables

patch 5a7b9512e4db8bfdd93b3a8d31c4ffdbf606cfbb
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 15:31:52 CEST 2020
  * writeUnrevert: remove the 'pending' argument
  
  This is a preparation for moving writeUnrevert to the Repository layer. The
  code we move from writeUnrevert into the command implementation is asking
  the user, so belongs to the UI layer.

patch 0e2c0bc21b7ee1d8e9b963a6ed7635d2295b6d5b
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 15:45:22 CEST 2020
  * move writeUnrevert and unrevertPatchBundle to Darcs.Repository.Unrevert

patch a22a4eb3d1e49231e917c3931cf550b114c9a0dd
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 15:59:33 CEST 2020
  * cleanup imports in Darcs.UI.Commands.Unrevert

patch 39ef756740bf8770f8bc119bb8314e935e7e1500
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 16:34:26 CEST 2020
  * move call to readRepo out of writeUnrevert
  
  This prepares for moving removeFromUnrevertContext from D.R.Hashed to
  D.R.Unrevert. It also makes it utterly clear that unrevert is unsafe: we
  read the repo and then modify the unrevert bundle /after/ it the changes
  have been finalized.

patch 86c2fefcc71d98a24fab89fb580fea07fdbdabea
Author: Ben Franksen <ben.franksen at online.de>
Date:   Fri Oct 23 18:14:30 CEST 2020
  * unrevert: use promptYorn instead of askUser

patch 6530cb226cb232608008afdc66f2214135588cee
Author: Ben Franksen <ben.franksen at online.de>
Date:   Tue Nov  3 08:37:35 CET 2020
  * simplify removeFromUnrevertContext

patch 10c7370af487b2842527697fb57b3dfc9e893415
Author: Ben Franksen <ben.franksen at online.de>
Date:   Sat Dec 19 15:51:36 CET 2020
  * move removeFromUnrevertContext to D.R.Unrevert

----------
files: make-writeunrevert-take-its-arguments-in-a-more-natural-order.dpatch, patch-preview.txt, unnamed
messages: 22574
nosy: bf
status: needs-screening
title: make writeUnrevert take its arguments in... (and 8 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2131>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 23698 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20201220/9b50bc57/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make-writeunrevert-take-its-arguments-in-a-more-natural-order.dpatch
Type: application/x-darcs-patch
Size: 24223 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20201220/9b50bc57/attachment-0003.bin>
-------------- next part --------------
.





More information about the darcs-devel mailing list