[darcs-devel] [patch2143] option refactors

[Ben Franksen]

New submission from Ben Franksen <ben.franksen at online.de>:

The first patch here is a an accidental dependency but I guess it doesn't
hurt to include it. The main thing are the last two patches. I've finally
bitten the bullet and reverted amend and record back to using [DarcsFlag]
instead of a configuration record. The diffing options refactor is also
something I wanted to do for a long time.

4 patches for repository http://darcs.net/screened:

patch 4330f2b8d149eee4bd6a7883ca4d919570be29ae
Author: Ben Franksen <ben.franksen at online.de>
Date:   Mon Oct 26 09:10:46 CET 2020
  * rollback: simplify by inlining undoItNow

patch 9c73fa5db0d98b0c081ccc066071d29f46a4d49b
Author: Ben Franksen <ben.franksen at online.de>
Date:   Mon Nov  9 20:24:20 CET 2020
  * add missing options to some optimize commands

patch 1d3e44c970d405378eea3081a6ca3083468d5fa3
Author: Ben Franksen <ben.franksen at online.de>
Date:   Mon Nov  2 09:49:06 CET 2020
  * unify diffing options
  
  This lets us treat all options that influence how we determine tree
  differences into a single data type, simplifying type signatures and call
  sites. The ScanKnown repo flag is removed, instead we add a third variant to
  LookForAdds.

patch c949ed8364be099ea66f00d1123f44cdb460c157
Author: Ben Franksen <ben.franksen at online.de>
Date:   Tue Nov  3 17:46:44 CET 2020
  * amend and record commands: back to using [DarcsFlag]
  
  Introducing configuration for these commands was done as an experiment and
  my conclusion is that it has failed. Haskell's records are just not flexible
  enough to be useful here.

----------
files: patch-preview.txt, rollback_-simplify-by-inlining-undoitnow.dpatch, unnamed
messages: 22587
nosy: bf
status: needs-screening
title: option refactors

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2143>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 47837 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20201221/55716895/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rollback_-simplify-by-inlining-undoitnow.dpatch
Type: application/x-darcs-patch
Size: 53548 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20201221/55716895/attachment-0003.bin>
-------------- next part --------------
.