[darcs-devel] [patch2134] assorted mostly trivial cleanups

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

>   * add more thorough checks in tests/oldfashioned.sh

OK

>   * use CommuteFn for genCommuteWhatWeCanRL and genCommuteWhatWeCanRL
>   
>   Also reformat their definition to make them more readable.

OK. The only non-formatting change is to replace a type with an alias.

>   * use promptYorn instead of askUser in SelectChanges
>   * D.R.ApplyPatches: print warnings to stderr
>   * fix typo in a comment
>   * break and overlong type signature
>   * fix comment in D.UI.Options.All
>   * amend: fix comment detail
>   * remove re-export of repo flags from D.R.State
>   * tests/issue1959-unwritable-darcsdir.sh: two more test cases
>   * break an overlong code line in D.R.Hashed
>   * trivial fix in output of add command
>   * make notInTreeParents local to addFiles
>   * fix the compatibility docs for Suspended
>   * remove a useless return ()
>   * minor cleanup in D.R.Pristine
>   * in optimize command, simplify path to hashed pristine

OK

>   * issue a debugMessage when catchall catches an exception

Good idea.


>   * tests/network/sshlib: use a dir local to our test dir as REMOTE_DIR
>   
>   This avoids filling up /tmp and improves repeatability.

OK, so this is safe because the ssh test always connects to
$(whoami)@localhost? It might be worth a comment on REMOTE_DIR that it
is really a local path, just being accessed via ssh.


>   * tests/EXAMPLE.sh: explain and follow best practices
>   * make test for remote darcs log a bit faster

OK

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2134>
__________________________________