[darcs-devel] [patch1982] diff command: make construction of trees... (and 5 more)
Ben Franksen
bugs at darcs.net
Tue Feb 11 08:13:10 UTC 2020
New submission from Ben Franksen <ben.franksen at online.de>:
Some more refactorings, originally only for the diff command. These depend
on a refactor of the matchFirst/SecondPatchset range matching functions
which in turn pulled in a dependency on a minor UI change to the 'show
dependencies' command.
Also follow up on review of patch1954 with comments in the diff command
implementation.
6 patches for repository http://darcs.net/screened:
patch c10013a29a6341db6ed596378539162dd4d75391
Author: Ben Franksen <ben.franksen at online.de>
Date: Sun Jan 26 20:35:15 CET 2020
* diff command: make construction of trees more obviously correct
patch 3f5def91ce548480b0e9aad4f1f67816769ff623
Author: Ben Franksen <ben.franksen at online.de>
Date: Wed Jan 29 10:33:31 CET 2020
* diff command: simplify display of the log
patch 428804718ada72c4dd91cc217586134cfb248798
Author: Ben Franksen <ben.franksen at online.de>
Date: Wed Jan 29 10:35:19 CET 2020
* refactor matchFirst/SecondPatchset
These functions now return a Maybe instead of being partial functions. This
simplifies the call sites and avoids duplicated checks.
patch 12bead4cc6802d4dd2f25c8672f36c7f750e10dd
Author: Ben Franksen <ben.franksen at online.de>
Date: Wed Jan 29 13:43:01 CET 2020
* review matching options for show dependencies
Showing the dependency graph makes the most sense for a range of patches. We
rename the combined matching option matchRange to matchOneOrRange (used for
diff) and add a different matchRange function that excludes the single patch
variants. Since the log command already has a function matchRange, we factor
that into D.UI.Command.Util and re-use it.
patch 2c65457ed16e2eb0c0d09de437e91a61b5e8a6fa
Author: Ben Franksen <ben.franksen at online.de>
Date: Sun Feb 9 21:53:26 CET 2020
* diff command: regroup and re-layout statements in doDiff
patch 9b08855dcf8cd10da3f067b9277bdfcee4eb0ebd
Author: Ben Franksen <ben.franksen at online.de>
Date: Tue Feb 11 09:09:54 CET 2020
* diff command: add comments to explain the subtleties
----------
files: diff-command_-make-construction-of-trees-more-obviously-correct.dpatch, patch-preview.txt, unnamed
messages: 21787
nosy: bf
status: needs-screening
title: diff command: make construction of trees... (and 5 more)
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1982>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 16726 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200211/da267b8b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-command_-make-construction-of-trees-more-obviously-correct.dpatch
Type: application/x-darcs-patch
Size: 36695 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200211/da267b8b/attachment-0003.bin>
-------------- next part --------------
.
More information about the darcs-devel
mailing list