[darcs-devel] [patch1980] split off D.R.Pristine and D.R.Traverse ... (and 4 more)

[Ben Franksen]

Ben Franksen <ben.franksen at online.de> added the comment:

>>   * split off D.R.Pristine and D.R.Traverse from D.R.Hashed
> 
> OK (I assume this is just moves)

Yes.

>>   * add utility functions handleOnly, handleOnlyIOError, and ifIOError
> 
> OK - there is handleJust etc in Control.Exception already, but using
> Maybe rather than Bool.

I tried handleJust but found it too awkward to use.

>> patch 6d97d20f213798d43f7a595591c3e308713de511
>> Author: Ben Franksen <ben.franksen at online.de>
>> Date:   Wed Feb  5 12:15:04 CET 2020
>>   * use ifIOError in D.R.Traverse and remove filterDirContents
> 
> I'm not too happy about replacing 'doesDirectoryExist'/'doesFileExist'
> with 'ifIOError'. That'll cover many more errors than just "it doesn't
> exist". Even though doesFileExist etc are themselves implemented with IO
> error catching, I am not convinced you'd get the same result for things
> like permission errors.

You are right. Will fix, probably adding ifDoesNotExistError and use
that instead.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1980>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 4211 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200225/970ecfb7/attachment.key>