[darcs-devel] [patch1982] diff command: make construction of trees... (and 5 more)

[Ben Franksen]

Ben Franksen <ben.franksen at online.de> added the comment:

>>   * refactor matchFirst/SecondPatchset
>>   
>>   These functions now return a Maybe instead of being partial functions. This
>>   simplifies the call sites and avoids duplicated checks.
> 
> Can firstMatch and secondMatch be rewritten as isJust .
> matchFirstPatchSet etc? I think they can, so we should. If not this
> refactoring may be unsound :-)

Good point. I checked and they can and I agree they should.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1982>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 4211 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200227/c4c144f1/attachment.key>