[darcs-devel] [patch2006] clean up the patch name TAG and UNDO prefix mess for good
Ben Franksen
bugs at darcs.net
Fri Feb 28 21:20:16 UTC 2020
New submission from Ben Franksen <ben.franksen at online.de>:
I am not yet screening this, sending so you can easily reproduce the
shrinker problem.
1 patch for repository http://darcs.net/screened:
patch 78297bfdb396eefe32e6b3ea603bd011c263ada0
Author: Ben Franksen <ben.franksen at online.de>
Date: Fri Feb 28 17:13:09 CET 2020
* clean up the patch name TAG and UNDO prefix mess for good
This rolls back most of patch 74e5d22381090db9e08f in favour of a safer and
more principled solution. The way tags are distinguished from regular
patches via a "TAG " prefix of the patch name is now fully hidden inside
Darcs.Patch.Info and treated as an implementation detail. To facilitate this
without too much disruption, we add a data type for patch names, forcing
client code to be explicit about whether they create a tag or a regular
patch. This uncovered a few bugs in the test suite where date and name were
accidentally swapped.
The "UNDO: " prefix that was traditionally prepended to the patch name for
patches with the _piLegacyIsInverted flag is now treated more uniformly, so
when such a patch gets amended without replacing the patch name, the prefix
will be retained as part of the patch name.
----------
files: clean-up-the-patch-name-tag-and-undo-prefix-mess-for-good.dpatch, patch-preview.txt, unnamed
messages: 21953
nosy: bf
status: needs-screening
title: clean up the patch name TAG and UNDO prefix mess for good
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2006>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 20727 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200228/2df578d3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clean-up-the-patch-name-tag-and-undo-prefix-mess-for-good.dpatch
Type: application/x-darcs-patch
Size: 52272 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200228/2df578d3/attachment-0003.bin>
-------------- next part --------------
.
More information about the darcs-devel
mailing list