[darcs-devel] [patch2062] add tests for URL/path classification functions

Ben Franksen bugs at darcs.net
Tue Jul 21 09:33:26 UTC 2020


Ben Franksen <ben.franksen at online.de> added the comment:

> Afraid they don't pass - see attached.

Hm. Indeed, the docs of System.FilePath.Windows.isValid claim that
colons in file paths are forbidden, except for specifying the "drive"
(volume).

Can you please check that this is correct i.e. Windows does not accept
paths with colons in them like those that fail the test?

If this is true, then the fix for issue2645 cannot work on Windows. This
calls the whole idea into question: if such a path is invalid on
Windows, then allowing them on a Posix system creates yet another
incompatibility when exchanging patches between repos residing on
different systems.

If this is not true, then we should report this as a bug against the
filepath library and create a work-around for it in darcs.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2062>
__________________________________


More information about the darcs-devel mailing list