[darcs-devel] [patch2064] tests/repairs.sh: remove obsolete settin... (and 2 more)

Ben Franksen bugs at darcs.net
Tue Jul 21 20:40:59 UTC 2020


New submission from Ben Franksen <ben.franksen at online.de>:

This is following up on review of patch2033.

Testing the issue more systematically revealed that repair can still fail to
detect missing hashed files, and not just those representing directories but
also those representing files.

The problem is that I forgot to expand the trees before updating the hashes.
Expanding forces reading all hashed files that represent directories and
afterwards darcsUpdateHashes will also force reading of those that represent
files. With this second fix 'darcs check' fails each time saying "Unable to
read the recorded state, try repair." and then repair says "Fixing pristine
tree...".

3 patches for repository http://darcs.net/screened:

patch ab91cc2137a2f36a82f26ef6e8fd85759173bfbc
Author: Ben Franksen <ben.franksen at online.de>
Date:   Tue Jul 21 22:07:39 CEST 2020
  * tests/repairs.sh: remove obsolete setting of ignore-times default

patch 5a5ca2de9c436a24d44dde0ca33b69ffe9e1efe2
Author: Ben Franksen <ben.franksen at online.de>
Date:   Tue Jul 21 22:18:42 CEST 2020
  * in darcs check/repair, expand the pristine tree
  
  This finally fixes detection of missing (hashed) pristine files.

patch 362a17e682299ab3ea9bfc8329a6bd80476d732e
Author: Ben Franksen <ben.franksen at online.de>
Date:   Tue Jul 21 22:09:09 CEST 2020
  * extend tests/repair.sh with missing pristine files

----------
files: patch-preview.txt, tests_repairs_sh_-remove-obsolete-setting-of-ignore_times-default.dpatch, unnamed
messages: 22232
nosy: bf
status: needs-screening
title: tests/repairs.sh: remove obsolete settin... (and 2 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2064>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 1428 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200721/e704a7aa/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tests_repairs_sh_-remove-obsolete-setting-of-ignore_times-default.dpatch
Type: application/x-darcs-patch
Size: 26141 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200721/e704a7aa/attachment-0003.bin>
-------------- next part --------------
.





More information about the darcs-devel mailing list