[darcs-devel] [patch2049] simplify the execution of the external d... (and 4 more)

Ganesh Sittampalam bugs at darcs.net
Tue Jul 21 21:49:09 UTC 2020


Ganesh Sittampalam <ganesh at earth.li> added the comment:

>   * simplify the execution of the external diff command

> -        withCurrentDirectory (toFilePath odir ++ "/..") $
> -            rundiff (takeFileName $ toFilePath odir) (takeFileName $ toFilePath ndir)
> +      rundiff (takeFileName $ toFilePath odir) (takeFileName $ toFilePath ndir)


OK - it took me a while to realise this is the same because the new code
is jumping out a nesting level...

>   * diff command: inline rundiff, cleanup, add a debug message and comments

...which you then explain in this patch :-)

>   * diff command: cleanup imports
>   * diff command: move helper functions to the end 
>   * diff command: pull check for correct %1/%2 usage into getDiffCmdAndArgs

All fine.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2049>
__________________________________


More information about the darcs-devel mailing list