[darcs-devel] [patch2008] introduce new rebase format (and 2 more)

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

On 07/03/2020 21:29, Ben Franksen wrote:

>> I could actually switch back to the "new-style" name given the idea of
>> using the rebase version number instead. On the other hand I'd somewhat
>> like to drop that particular name,
> 
> I don't like the name too much either. But we should postpone this move
> for two reasons: One is that we aren't sure what name the next release
> will have. More importantly, I think this should /not/ be mixed with the
> changes in the rebase format you are going to make. The move from
> old-style to new-style rebase was of quite a different quality: it did
> not concern the format of the rebase patch itself, but rather its
> location and the way it is handled by the Patch and Repository code.

OK.

> I don't see any problem with this approach. There is no rule that says
> all intermediate states of our repo have to be compatible (or even
> buildable, though of course we try to achieve that).

OK. You'll just need to be careful not to use those intermediate states.

> I don't think this is necessary. It is also not very effective. If you
> really want to be sure, you should disable the rebase state so that no
> command touches it. But I think this is not justified.

Well, that's not possible either as it breaks all the tests (and proving
they keep working in the intermediate states is important too.) But
never mind.

>> Removing it would also be a good point to add backwards compatibility
>> tests for the new format. Any future changes would then need a new
>> upgrade path.
> 
> I think these tests should be part of the bundle right from the beginning.

I can add them as part of the bundle, but obviously they have to be
logically after finalising the new format.

Given this discussion I'll probably reject this bundle as the key bits
with the new format don't make any sense any more, and send in an
updated version of the other bundle so it can be accepted and pushed
together.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2008>
__________________________________