[darcs-devel] patch review

Ben Franksen ben.franksen at online.de
Fri Mar 13 22:07:32 UTC 2020


Am 02.03.20 um 13:28 schrieb Ganesh Sittampalam:
> My workflow has varied over time, but at the moment I completely
> separate reviewing and pushing. I review things in one clone, mark them
> as reviewed (i.e. accepted-pending-tests) on the patch tracker, and move
> on. Most of the time when I'm reviewing I don't even build the code, I
> just read it.
> 
> I use a separate clone specifically for running tests. When I'm doing
> that, I look at all the accepted-pending-tests patches, apply what I
> can, run the tests and immediately push. In that scenario I never pull
> from screened directly, and if I can't apply something because of
> dependencies then I just omit it. If that means a single item on the
> tracker will be part-merged, I will usually give it a once-over to make
> sure that there aren't any hidden gotchas the tests wouldn't reveal.

This sounds like a good way to lessen the inherent tension. I think I
will adopt that method.

Cheers
Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 4211 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20200313/ee74d204/attachment.key>


More information about the darcs-devel mailing list