[darcs-devel] [patch2152] t/n/issue1932-remote.sh: loosen the chec... (and 1 more)

Ben Franksen bugs at darcs.net
Sun Jan 24 11:09:43 UTC 2021


Ben Franksen <ben.franksen at online.de> added the comment:

-[ -n "$(grep 'ssh: Could not resolve hostname invalid' log)" ]
+fgrep 'ssh: Could not resolve host' log

Fine. However, would you mind replacing fgrep with grep -F or just 
plain grep? I think that is more portable.

-( http_proxy= darcs clone 
http://www.bogus.domain.so.it.will.surely.fail.com || true ) 2>&1 | tee 
log
+( http_proxy= darcs clone 
http://www.bogus.domain.so.it.will.surely.fail.example.org. || true ) 
>log 2>&1

I agree this is safer.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2152>
__________________________________


More information about the darcs-devel mailing list