[darcs-devel] [patch2161] resolve issue2674 (and a few more)

[Ganesh Sittampalam]

Ganesh Sittampalam <ganesh at earth.li> added the comment:

On 09/05/2021 10:38, Ben Franksen wrote:

>>>  * test that we cannot record patches that depend on broken moves
>>
>> Do we really care about this test working before the fix for issue2674?
>> The approach seems a bit convoluted.
> 
> It is, but I wanted to make sure this is covered because of the concerns
> you raised on #darcs when we first discussed this. This test gives
> justification (in addition to the theoretical considerations) that we
> can really drop the broken move changes from existing patches without
> breaking anything, even if they are burried deep inside a repo's history.

I'm still a bit confused about why the script is needed. Why not just
use the tarball all the time? Anyway, this bundle is ok to push
regardless of this point.


> If we agree that the changes in this bundle are correct so far, then the
> next question is how much of that to include in a new patch release 3.16.4.

I agree that the changes are correct. I don't feel too strongly about
hwo much to include, it could just be all of it.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch2161>
__________________________________