[darcs-users] push mail error?

David Roundy droundy at abridgegame.org
Mon May 19 10:37:37 UTC 2003


On Sun, May 18, 2003 at 09:25:30PM +0200, Peter Simons wrote:
> I just pushed a minor fix for the Makefile to your repository at
> abridgegame.org. Not only will it be interesting to see what happens
> :-), I also found one glitch:
> 
>  | Shall I pull this patch? [ynvaswh]
> 
> should say "push" in this case,

Fixed.  Would you believe I had gone to all the work to pass the command
name into that function (which is the same used by pull, obviously), but
then forgot to use it in the prompt?  :)

> ...and one potential problem: My sendmail
> logged this, when the mail got sent out:
> 
>  | POSSIBLE ATTACK from [UNKNOWN]: newline in string "darcs-users at abridgegame.org "

I have a probable fix for this in the repository, so you could try again
with the fixed version.  I was just slurping in a file to use as the email
address, which generally will end with a newline, so now I just grab up
until the first newline.

> I had no chance to _see_ it myself (it might be nice to have a flag
> that says "send me a Cc")...

Hmmmm.  Probably I would prefer to have the option be to Cc arbitrary
people, since I imagine one might often want to Cc someone else to let him
see the change...

Currently you could get this effect by using --target
"darcs-users at abridgegame.org youremailaddresss" which I believe will send
to both email addresses.  But then you lose the benefit of having the
target email automatically specified by the repository to which you are
pushing.

> ... but you will probably get it, so you might want to look at the
> headers whether there's anything funny in there.

Alas, no.  Pushes to ag.o/r/d go to this list, so you would have seen it.
I don't use sendmail (exim instead), so your configuration is perhaps
untested.  It may be that the newline caused sendmail to get confused, so
you can try again with the recent patch, and if that works, great.  If you
want to experiment, you can also try pushing to ag.o/r/darcs-test, which
will bounce any pushes that aren't signed by my key, or of course you could
use the --target option to push at yourself.
-- 
David Roundy
http://www.abridgegame.org




More information about the darcs-users mailing list