[darcs-users] pull -m is not honored on the first patch

David Roundy droundy at abridgegame.org
Wed Apr 28 11:16:49 UTC 2004


On Tue, Apr 27, 2004 at 11:52:13PM -0400, Andrew Pimlott wrote:
> In pull, the -m expression is not applied to the first candidate patch;
> this patch is offered for pulling unconditionally.  This seems wrong and
> is not consistent with unpull.

...

> The difference in the code is that unpull calls
> with_selected_patch_from_repo, while pull calls with_selected_changes.
> The latter calls text_select on the first patch, which unconditionally
> offers it, and only calls tentatively_text_select, which checks whether
> the patch matches the expression, on subsequent patches.

Thanks for the bug report and the diagnostic! Changing the first call from
text_select to tentatively_text_select fixes the problem!
-- 
David Roundy
http://www.abridgegame.org




More information about the darcs-users mailing list