[darcs-users] darcs push problem: cannot find file

David Roundy droundy at abridgegame.org
Sun Nov 21 12:40:10 UTC 2004


On Sun, Nov 21, 2004 at 12:32:03AM -0700, Will wrote:
> David Roundy <droundy at abridgegame.org> writes:
> 
> > On Fri, Nov 19, 2004 at 10:41:08AM -0700, Will wrote:
> >>
> >> One ramification of this change is that when you enter the patch name
> >> interactively from cmd.exe it seems to contain a '\r', should it be
> >> stripped?
> >
> > Yeah, I don't think we want to allow '\r' in patch names.  Can you submit a
> > patch for this?
> 
> The same problem will happen with other input, so I guess we'd have to
> replace every call to 'getLine' with a similar function that strips
> '\r' too?

Yeah, that makes sense.  Bonus points if we can do it in a way that costs
zero on non-windows systems... perhaps the C preprocessor is our friend
here.  Not that it'll cost much in any case, but still, as a matter of
principle...
-- 
David Roundy
http://www.darcs.net




More information about the darcs-users mailing list