[darcs-users] Re: hard to reproduce bug with 'changes --last'

[Mark Stosberg]

On 2004-10-26, David Roundy <droundy at abridgegame.org> wrote:
> On Tue, Oct 26, 2004 at 12:39:19AM -0400, Andrew Pimlott wrote:
>> On Tue, Oct 26, 2004 at 02:45:42AM +0000, Mark Stosberg wrote:
>> > I just tried this in my copy of the darcs archive:
>> > 
>> > $ darcs changes --last=1 Changes.lhs
>> > Changes to Changes.lhs:
>> > 
>> > #####
>> > 
>> > No entry was shown! This only happens with the "--last" flag. 
>> > However, I couldn't confirm this a bug in the general case. Using
>> > the same binary (1.0.0rc3), I create a simple test case and saw that 
>> > "--last=1" worked fine. 
>> > 
>> > I'm not sure what's different about this case or file. I'd be curious
>> > if other people with darcs repos see the same thing.
>> 
>> I think this is because --last is dumb:  It's showing you which patches,
>> out of the last n in the repository, affected Changes.lhs.  It should
>> probably be corrected to show the last n of the patches that affected
>> Changes.lhs.
>
> Indeed, that's precisely how it works.  The problem is that --last is
> treated analagously to --from-tag etc, which obviously need to be run prior
> to filtering by file.  Probably --last should be interpereted differently,
> as a post-processing step.

That's for the clarification. I just submitted a (failing) test for the behavior
that expected for when/if someone wants to implement it. :)

	Mark

-- 
http://mark.stosberg.com/